Allocate buffers with supported modifiers #236
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wl-drm is a private protocol and while all compositors support it now, it may be removed in future. This adds dependency on libdrm to be able to get the device path from dev_t returned from dmabuf feedback main_device.
Use dmabuf feedback to get supported modifiers. Using tiled layout is more efficient than linear and should give better performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocate buffers with supported modifiers
Use dmabuf feedback to get supported modifiers. Using tiled layout is
more efficient than linear and should give better performance.
Draft for now because it requires #235 and also it's unclear if this causes any issues with Intel. Ideally we would query VAAPI for supported modifiers, however no driver (not even Intel) implements this. It's not an issue with Mesa/AMD because it will import any supported modifier without an issue, but I think Intel driver is more picky here. We can try to filter out problematic modifiers ourselves, or simply disable this path for Intel.