Upgrade typescript and fix unknown ypes

[kr8n3r]

What

In Typescript 4.4.2 there is a breaking change https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#using-unknown-in-catch-variables

Our acceptance tests that run on staging and prod fail.

This adds type any to variable in the try/catch block.

more info:

• Add flag to change catch variables' default types to unknown microsoft/TypeScript#41013
• https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables

How to review

• if you have a dev env, deploy there and run the acceptance test
• alternatively, obtain envs from cf and credhub, export variable to point to dev01 or dev02 and run npm run test:acceptance

Who can review

not @kr8n3r

---

🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️🚨

[kr8n3r]

@paroxp what do you think of changes in 48079c9 ?

as we can't do catch ( err: AxiosError) this is the best i could come up to check that type is AxiosError

nevermind, doesn't work

[paroxp]

Yeah, this looks good. I imagine you still need any or unknown type. And if I think about it, there could be number of errors that could be thrown. Us doing the checks and resolving to default behaviour if it's not something we expected is OK I think.

[kr8n3r]

Yeah, this looks good. I imagine you still need any or unknown type. And if I think about it, there could be number of errors that could be thrown. Us doing the checks and resolving to default behaviour if it's not something we expected is OK I think.

unknown is now the default with typescript 4.4.2 and --strict

as tests are now failing will have to look at a different solution, might have to be something so I can do
err instance of <customErrorThatExtendsAxiosError>

for reasons I don't know request here doesn't result in an AxiosError

[kr8n3r]

@paroxp going back to previous any type for the error as it's become to cumbersome