Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Fixes Checkpointing #5220

Merged
merged 40 commits into from
May 29, 2021
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
fb6b00b
Removes unused variable
dirkgr May 19, 2021
7d15a73
Formatting
dirkgr May 19, 2021
1475729
Make sure we always restore the model's weights properly
dirkgr May 20, 2021
f247cdd
Give TrainerCallbacks the ability to save and load state dicts
dirkgr May 20, 2021
fd14dd7
Give MovingAverage the ability to save and load state dicts
dirkgr May 20, 2021
27d90d0
Do not set gradients to None
dirkgr May 20, 2021
7612741
Typo
dirkgr May 20, 2021
d894b25
Remove unused variable
dirkgr May 20, 2021
e0e917e
Typo
dirkgr May 20, 2021
e52e7ad
Entirely new checkpointing code
dirkgr May 24, 2021
bead35e
Formatting
dirkgr May 24, 2021
c5e8537
Merge remote-tracking branch 'origin/main' into Checkpointing
dirkgr May 24, 2021
6128a88
Make mypy happy
dirkgr May 24, 2021
cef052d
Makes the no-op trainer work with the new checkpointer
dirkgr May 24, 2021
fdc8db7
Mark epochs as completed when they're skipped
dirkgr May 24, 2021
b3b65c2
Changelog
dirkgr May 24, 2021
6c944c2
Fixes how we get the best weights after a training run
dirkgr May 24, 2021
0799137
Mypy is annoying
dirkgr May 24, 2021
3cae291
Callback fixes
dirkgr May 25, 2021
e04eae2
Fix the no op trainer
dirkgr May 25, 2021
d873df1
Simplify
dirkgr May 25, 2021
5480fd5
Assorted checkpointer fixes
dirkgr May 25, 2021
eafb48a
Mypy is now happy
dirkgr May 25, 2021
37c13a7
Fixed all the tests except for one
dirkgr May 25, 2021
872ac20
Removed unused variable
dirkgr May 25, 2021
b8545fd
Fix trainer restore logic
dirkgr May 25, 2021
273386d
Fix test for trainer restore logic
dirkgr May 25, 2021
abc7826
Merge remote-tracking branch 'origin/main' into Checkpointing
dirkgr May 25, 2021
69909ff
Check the Checkpointing branch of the models repo
dirkgr May 25, 2021
4ca4912
Help mypy along
dirkgr May 25, 2021
7af394f
Fixed finalizing logic
dirkgr May 25, 2021
302c672
More mypy stuff
dirkgr May 25, 2021
cd33ad2
Merge branch 'main' into Checkpointing
dirkgr May 25, 2021
153608b
Merge branch 'main' into Checkpointing
dirkgr May 27, 2021
9f97c38
Merge branch 'main' into Checkpointing
dirkgr May 27, 2021
f95d437
Merge branch 'main' into Checkpointing
dirkgr May 27, 2021
7811679
Merge branch 'main' into Checkpointing
dirkgr May 28, 2021
82353ed
Update allennlp/training/checkpointer.py
dirkgr May 29, 2021
5537194
Merge remote-tracking branch 'origin/main' into Checkpointing
dirkgr May 29, 2021
5aa9b00
Make weaker claims
dirkgr May 29, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Give TrainerCallbacks the ability to save and load state dicts
dirkgr committed May 20, 2021
commit f247cdd1ba19732cf93919445d7a808d3810aa42
6 changes: 6 additions & 0 deletions allennlp/training/callbacks/callback.py
Original file line number Diff line number Diff line change
@@ -77,5 +77,11 @@ def on_end(
"""
pass

def state_dict(self) -> Dict[str, Any]:
return {}

def load_state_dict(self, state_dict: Dict[str, Any]) -> None:
pass
Comment on lines +80 to +84
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.



TrainerCallback.register("null")(TrainerCallback)