This repository was archived by the owner on Dec 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fixes Checkpointing #5220
Merged
+1,455
−1,393
Merged
Fixes Checkpointing #5220
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
fb6b00b
Removes unused variable
dirkgr 7d15a73
Formatting
dirkgr 1475729
Make sure we always restore the model's weights properly
dirkgr f247cdd
Give TrainerCallbacks the ability to save and load state dicts
dirkgr fd14dd7
Give MovingAverage the ability to save and load state dicts
dirkgr 27d90d0
Do not set gradients to None
dirkgr 7612741
Typo
dirkgr d894b25
Remove unused variable
dirkgr e0e917e
Typo
dirkgr e52e7ad
Entirely new checkpointing code
dirkgr bead35e
Formatting
dirkgr c5e8537
Merge remote-tracking branch 'origin/main' into Checkpointing
dirkgr 6128a88
Make mypy happy
dirkgr cef052d
Makes the no-op trainer work with the new checkpointer
dirkgr fdc8db7
Mark epochs as completed when they're skipped
dirkgr b3b65c2
Changelog
dirkgr 6c944c2
Fixes how we get the best weights after a training run
dirkgr 0799137
Mypy is annoying
dirkgr 3cae291
Callback fixes
dirkgr e04eae2
Fix the no op trainer
dirkgr d873df1
Simplify
dirkgr 5480fd5
Assorted checkpointer fixes
dirkgr eafb48a
Mypy is now happy
dirkgr 37c13a7
Fixed all the tests except for one
dirkgr 872ac20
Removed unused variable
dirkgr b8545fd
Fix trainer restore logic
dirkgr 273386d
Fix test for trainer restore logic
dirkgr abc7826
Merge remote-tracking branch 'origin/main' into Checkpointing
dirkgr 69909ff
Check the Checkpointing branch of the models repo
dirkgr 4ca4912
Help mypy along
dirkgr 7af394f
Fixed finalizing logic
dirkgr 302c672
More mypy stuff
dirkgr cd33ad2
Merge branch 'main' into Checkpointing
dirkgr 153608b
Merge branch 'main' into Checkpointing
dirkgr 9f97c38
Merge branch 'main' into Checkpointing
dirkgr f95d437
Merge branch 'main' into Checkpointing
dirkgr 7811679
Merge branch 'main' into Checkpointing
dirkgr 82353ed
Update allennlp/training/checkpointer.py
dirkgr 5537194
Merge remote-tracking branch 'origin/main' into Checkpointing
dirkgr 5aa9b00
Make weaker claims
dirkgr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Give TrainerCallbacks the ability to save and load state dicts
commit f247cdd1ba19732cf93919445d7a808d3810aa42
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅