This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Fixes Backbone / Model MRO inconsistency #5148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ordering of parent classes in Backbone is backwards from Model's, which leads to inconsistent MRO issues if one wants to implement their Backbone by multi-inheriting from an existing Model.
dirkgr
pushed a commit
that referenced
this pull request
May 10, 2021
The ordering of parent classes in Backbone is backwards from Model's, which leads to inconsistent MRO issues if one wants to implement their Backbone by multi-inheriting from an existing Model.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering of parent classes in
Backboneis backwards fromModel's, which leads to inconsistent MRO issues if one wants to implement theirBackboneby multi-inheriting from an existingModel.