Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Add end+trainer callbacks to Trainer.from_partial_objects #4751

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Add end+trainer callbacks to Trainer.from_partial_objects #4751

merged 3 commits into from
Oct 26, 2020

Conversation

jacobdanovitch
Copy link
Contributor

Fixes #4750 . Makes end_callbacks and trainer_callbacks instantiable from config files.

@jacobdanovitch
Copy link
Contributor Author

@epwalsh I also added end_callbacks, not sure if those should be included or just passed as epoch_callbacks and handled by the user.

epwalsh
epwalsh reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@epwalsh epwalsh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes thanks for adding end_callbacks as well. This looks great as-is. Just one comment about the CHANGELOG.

@epwalsh epwalsh merged commit 27edfbf into allenai:master Oct 26, 2020
@jacobdanovitch jacobdanovitch deleted the jacobdanovitch/callbacks-from-config branch October 26, 2020 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@epwalsh epwalsh epwalsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trainer_callbacks parameter missing from GradientDescentTrainer.from_partial_objects
2 participants
@jacobdanovitch @epwalsh