Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): array.spec.test 容错部分将注释替换为 expect, 并将注释中的错误进行修正 #3861

Conversation

charlzyx
Copy link
Contributor

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

core/src/tests/array.spec.test 容错部分test('fault tolerance', () => {} 部分测试注释不正确, 调整如下

  1. 注释改为 expect
  2. 修正错误部分(依据为当前 formily_next 分支实际运行结果)

在尝试修复 #3855 (comment) 这个问题, 发现一些测试用例不全, 注释错误, 给于修正。

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b3edf2d) 96.58% compared to head (30214b5) 96.58%.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #3861   +/-   ##
=============================================
  Coverage         96.58%   96.58%           
=============================================
  Files               152      152           
  Lines              6675     6675           
  Branches           1860     1801   -59     
=============================================
  Hits               6447     6447           
  Misses              228      228           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@janryWang janryWang merged commit 44f0810 into alibaba:formily_next Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants