bug: Fixed unexpected error with invalid api key when exception-raising is not configured #1682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the open bug issue #1657 .
Bug
If geocoder is configured with MapBox and invalid api key and
always_raise
doesn't containGeocoder::InvalidApiKey
,Geocoder.search
will throw the following error.Why this happened
results(query)
is evaluated asfalse
ingeocoder/lib/geocoder/lookups/base.rb
Line 46 in 5b379a5
because
raise_error
is called in theresults
method, andresults
returnsfalse
ifalways_raise
doesn't contain the argument error.