Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --skip-modifiers flag #68

Merged
merged 2 commits into from
Jun 9, 2024
Merged

feat: add --skip-modifiers flag #68

merged 2 commits into from
Jun 9, 2024

Conversation

alexfertel
Copy link
Owner

Resolves #66

Note that I named the flag --skip-modifiers (or -m) because that's slightly more accurate and is consistent with the other flags.

@alexfertel alexfertel self-assigned this Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.9%. Comparing base (3991e37) to head (1d83b51).

Current head 1d83b51 differs from pull request most recent head d90a863

Please upload reports for the commit d90a863 to get more accurate results.

Additional details and impacted files
Files Coverage Δ
src/check/context.rs 88.3% <100.0%> (+0.1%) ⬆️
src/check/rules/structural_match.rs 96.1% <100.0%> (+<0.1%) ⬆️
src/hir/combiner.rs 95.6% <ø> (-0.1%) ⬇️
src/hir/mod.rs 100.0% <100.0%> (ø)
src/sol/translator.rs 98.8% <100.0%> (+<0.1%) ⬆️
src/check/mod.rs 91.2% <75.0%> (-0.9%) ⬇️
src/config.rs 86.1% <85.7%> (-0.6%) ⬇️
src/scaffold/mod.rs 87.5% <50.0%> (-0.9%) ⬇️

... and 2 files with indirect coverage changes

@alexfertel alexfertel merged commit 1184daa into main Jun 9, 2024
1 of 5 checks passed
@alexfertel alexfertel deleted the ignore-modifiers branch June 9, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Ignore modifier definitions in the test contract
1 participant