Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3408]Do not use "since" parameter in identifier search. #3409

Merged
merged 1 commit into from
Feb 6, 2020
Merged

[#3408]Do not use "since" parameter in identifier search. #3409

merged 1 commit into from
Feb 6, 2020

Conversation

stellanl
Copy link
Contributor

@stellanl stellanl commented Feb 6, 2020

Before the PR (what is the issue or what needed to be done)

The since string was used for two different lookups.

The solution

Use it only for the same lookup it was obtained from.

Screenshots (if appropriate)

Reviewer Checklist

  • Added an explanation about the work done
  • Connected the PR and the issue on Zenhub
  • Added a test plan to the issue
  • Updated the copyright header (when relevant)
  • Formatted the code
  • Added a documentation (if relevant)
  • Added some unit tests (if relevant)

@valllllll2000 valllllll2000 merged commit 6a9dbde into develop Feb 6, 2020
@valllllll2000 valllllll2000 deleted the issue/3408-only-one-since-in-search branch February 6, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valllllll2000 valllllll2000 valllllll2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellanl @valllllll2000