Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3394] handle null names in FolderSelector comparator #3395

Merged
merged 1 commit into from
Jan 16, 2020
Merged

[#3394] handle null names in FolderSelector comparator #3395

merged 1 commit into from
Jan 16, 2020

Conversation

marvinkome
Copy link
Contributor

Before the PR (what is the issue or what needed to be done)

survey names that were null would break when you run name.toUpperCase.

The solution

Check if survey name is null before comparing strings

Screenshots (if appropriate)

Reviewer Checklist

  • Added an explanation about the work done
  • Connected the PR and the issue on Zenhub
  • Added a test plan to the issue
  • Updated the copyright header (when relevant)
  • Formatted the code
  • Added a documentation (if relevant)
  • Added some unit tests (if relevant)

@valllllll2000 valllllll2000 merged commit 53e4b23 into develop Jan 16, 2020
@muloem muloem deleted the issue-3394/handle-null-survery-name branch January 16, 2020 11:50
@muloem muloem restored the issue-3394/handle-null-survery-name branch January 16, 2020 11:50
@iperdomo iperdomo deleted the issue-3394/handle-null-survery-name branch February 19, 2020 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valllllll2000 valllllll2000 valllllll2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinkome @valllllll2000