[#3380] Update dev image + code clean up #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update to the latest akvo/akvo-flow-builder image that is based on a published google/cloud-sdk - Remove references to ruby build process, e.g. RAKEP_MODE BUNDLE etc We're now using `node` to bundle our client application - Use `npm ci` instead of `npm install` as part of the build https://docs.npmjs.com/cli/ci.html - Cache `$HOME/.npm` to speed up builds
dlebrero
reviewed
Jan 15, 2020
| @@ -5,7 +5,8 @@ services: | |||
| - docker | |||
| cache: | |||
| directories: | |||
| - $HOME/.m2 | |||
| - "$HOME/.m2" | |||
| - "$HOME/.npm" | |||
There was a problem hiding this comment.
For my information, what is stored here? I thought npm does not use a global path, but just messes around with the node_modules dir
There was a problem hiding this comment.
From the documentation page
# keep the npm cache around to speed up installs
cache:
directories:
- "$HOME/.npm"
https://docs.npmjs.com/cli/ci.html
In a fresh container:
cd $HOME/.npm/
~/.npm # du -sh
43.6M .
The actual content can be found here:
https://gist.github.com/iperdomo/042af3dafe282012e3cb66230a51da2b
npm ci deletes the local node_modules if exists, before installing the versions used in package-lock.json
dlebrero
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on a published google/cloud-sdk
We're now using
nodeto bundle our client applicationnpm ciinstead ofnpm installas part of the buildhttps://docs.npmjs.com/cli/ci.html
$HOME/.npmto speed up builds