Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3339] - Fix footer on add/edit tab #3356

Merged
merged 1 commit into from
Dec 16, 2019
Merged

[#3339] - Fix footer on add/edit tab #3356

merged 1 commit into from
Dec 16, 2019

Conversation

marvinkome
Copy link
Contributor

The solution

Add padding to .device-action-page .body to remove overlap with footer

Screenshots (if appropriate)

image

Reviewer Checklist

  • Added an explanation about the work done
  • Connected the PR and the issue on Zenhub
  • Added a test plan to the issue
  • Updated the copyright header (when relevant)
  • Formatted the code
  • Added a documentation (if relevant)
  • Added some unit tests (if relevant)

@marvinkome marvinkome merged commit 0d9d4b8 into develop Dec 16, 2019
@muloem muloem deleted the issue-3339/fix-footer-on-add/edit-tab branch January 9, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valllllll2000 valllllll2000 valllllll2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinkome @valllllll2000