Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2559] Add a new redirect filter #3238

Merged
merged 1 commit into from
Oct 16, 2019
Merged

[#2559] Add a new redirect filter #3238

merged 1 commit into from
Oct 16, 2019

Conversation

muloem
Copy link
Member

@muloem muloem commented Oct 16, 2019

Before the PR (what is the issue or what needed to be done)

  • A redirect was added to the HTML in the page but the public maps still showed for a few seconds before the redirect was activated.

The solution

  • Add a filter that redirects even before loading the public HTML pages

Screenshots (if appropriate)

Checklist

  • Connect the issue
  • Test plan
  • Copyright header
  • Code formatting
  • Documentation

@muloem muloem requested a review from stellanl October 16, 2019 16:51
stellanl
stellanl approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@stellanl stellanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@stellanl stellanl merged commit 5e2defc into release/1.10 Oct 16, 2019
@stellanl stellanl deleted the issue/2559-redirect-from-landing-page branch October 16, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellanl stellanl stellanl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muloem @stellanl