Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3173]Fix logic. #3215

Merged
merged 2 commits into from
Oct 3, 2019
Merged

[#3173]Fix logic. #3215

merged 2 commits into from
Oct 3, 2019

Conversation

stellanl
Copy link
Contributor

@stellanl stellanl commented Oct 3, 2019

Before the PR (what is the issue or what needed to be done)

Messed up the logic when I removed the forceSplit boolean.

The solution

Fix it. Improve comment.

Screenshots (if appropriate)

Checklist

  • Connect the issue
  • Test plan
  • Copyright header
  • Code formatting
  • Documentation

@stellanl stellanl requested a review from muloem October 3, 2019 13:01
@stellanl stellanl merged commit 6a5e4c8 into develop Oct 3, 2019
@stellanl stellanl deleted the issue/3173-augment-assignment-splitting-script branch October 3, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muloem muloem muloem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellanl @muloem