Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3142] Retrieve entities with known IDs in a single batch request #3144

Merged
merged 5 commits into from
Jul 29, 2019
Merged

[#3142] Retrieve entities with known IDs in a single batch request #3144

merged 5 commits into from
Jul 29, 2019

Conversation

muloem
Copy link
Member

@muloem muloem commented Jul 25, 2019

Before the PR (what is the issue or what needed to be done)

  • Entities with known IDs retrieved one by one by repeatedly making requests to the datastore for each entity.

The solution

  • We make a single request to the datastore with the list of IDs

Screenshots (if appropriate)

Checklist

  • Connect the issue
  • Test plan
  • Copyright header
  • Code formatting
  • Documentation

muloem added 4 commits July 25, 2019 12:33
@muloem
[#3142] Make datanucleus classes available at compile time
43ee3b0 
* Needed in order to correctly compile the NucleusObjectNotFoundException class
@muloem
[#3142] Retrieve entities in a batch when a list of IDs is provided
0d8bbcd 
* This reduces the about of chatter between the datastore and the backend when retrieving multiple entities with known keys
@muloem
[#3142] Add missing import
f4a1c21
@muloem
[#3142] Update copyright year
dcd9545
@muloem muloem requested a review from valllllll2000 July 25, 2019 11:15
@muloem
[#3142] Catch the exception when an object with a provided ID doesnt …
c016257 
…exist

* Fall back to the retrieval of items one-by-one incase one of the items is missing and causes an exception that prevents batch retrieval
@valllllll2000 valllllll2000 merged commit 146595a into develop Jul 29, 2019
@valllllll2000 valllllll2000 deleted the issue/3142-optmimise-batch-retrieval branch July 29, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valllllll2000 valllllll2000 valllllll2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muloem @valllllll2000