Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3108] Refactor assignments entities generation #3143

Merged
merged 3 commits into from
Jul 24, 2019
Merged

[#3108] Refactor assignments entities generation #3143

merged 3 commits into from
Jul 24, 2019

Conversation

muloem
Copy link
Member

@muloem muloem commented Jul 24, 2019

Before the PR (what is the issue or what needed to be done)

  • The assignments entities code attempted to update assignments by identifying which entities needed to be newly generated, which ones deleted and which ones possibly updated.

The solution

  • Simplify the entities generation by always deleting all entitites associated with an assignment an regenerating the new ones

Screenshots (if appropriate)

Checklist

  • Connect the issue
  • Test plan
  • Copyright header
  • Code formatting
  • Documentation

muloem added 3 commits July 22, 2019 13:09
@muloem
[#3108] Throw a 404 exception if the assignment is not found
39a65e3
@muloem
[#3108] Refactor generation of survey assignment entities
52b84b3 
* Instead of updating the individual survey-device entities based on changes in the assignment, we remove all the previously generated ones and generate new ones.
@muloem
[#3108] Remove unused variable
6e165da
@muloem muloem requested a review from stellanl July 24, 2019 05:25
stellanl
stellanl approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@stellanl stellanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed

@stellanl stellanl merged commit 2c33e35 into develop Jul 24, 2019
@stellanl stellanl deleted the issue/3108-assignments-backend branch July 24, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellanl stellanl stellanl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muloem @stellanl