Disable saving nameless assignment (connect #3132) #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +64,9 @@ FLOW.AssignmentsListView = FLOW.ReactComponentView.extend(observe({ | |||
| assignmentEdit(action, assignmentId) { | |||
| switch (action) { | |||
| case 'new': { | |||
| const newAssignment = FLOW.store.createRecord(FLOW.SurveyAssignment, {}); | |||
| const newAssignment = FLOW.store.createRecord(FLOW.SurveyAssignment, { | |||
| name: Ember.String.loc('_new_question_please_change_name'), | |||
There was a problem hiding this comment.
why question? is the string identical? if so maybe we should rename it something more meaningful?
valllllll2000
suggested changes
Jul 8, 2019
valllllll2000
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the PR (what is the issue or what needed to be done)
Save option available even when no assignment name is set resulting in a sometimes empty assignments
The solution
Add validation for assignment name
Screenshots (if appropriate)
Checklist