Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3098] Upgrade library versions #3099

Merged
merged 4 commits into from
May 23, 2019
Merged

[#3098] Upgrade library versions #3099

merged 4 commits into from
May 23, 2019

Conversation

muloem
Copy link
Member

@muloem muloem commented May 17, 2019

Before the PR (what is the issue or what needed to be done)

  • We had security warnings and missing peer package warnings

The solution

  • Upgrade relevant npm packages
  • Upgrade maven packages for spring and spring-security

Screenshots (if appropriate)

Checklist

  • Connect the issue
  • Test plan
  • Copyright header
  • Code formatting
  • Documentation

@muloem muloem requested review from stellanl and finnfiddle May 17, 2019 17:31
@muloem muloem self-assigned this May 17, 2019
@muloem muloem changed the base branch from develop to release/1.9.47 May 23, 2019 12:07
finnfiddle
finnfiddle approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@finnfiddle finnfiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muloem muloem merged commit c966299 into release/1.9.47 May 23, 2019
@muloem muloem deleted the issue/3098-upgrade-library-versions branch May 23, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnfiddle finnfiddle finnfiddle approved these changes

@stellanl stellanl Awaiting requested review from stellanl

Assignees

@muloem muloem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muloem @finnfiddle