remove ruby build altogether #3035

[finnfiddle]

Before the PR (what is the issue or what needed to be done)

Now that we are using webpack for the static assets build - we dont need ruby anymore.

The solution

Remove ruby and all deps.

Screenshots (if appropriate)

Checklist

• Connect the issue
• Test plan
• Copyright header
• Code formatting
• Documentation

[dlebrero]

With a clean checkout, I am getting an error, which I guess is due to running npm install and npm run in parallel as a mention in another comment:

kvo-flow_1 | > akvo-flow@ build:dev /app/src/Dashboard
akvo-flow_1 | > babel-node ./scripts/buildDev.js
akvo-flow_1 |
akvo-flow_1 | sh: babel-node: not found
akvo-flow_1 | npm ERR! file sh
akvo-flow_1 | npm ERR! code ELIFECYCLE
akvo-flow_1 | npm ERR! errno ENOENT
akvo-flow_1 | npm ERR! syscall spawn
akvo-flow_1 | npm ERR! akvo-flow@ build:dev: babel-node ./scripts/buildDev.js
akvo-flow_1 | npm ERR! spawn ENOENT
akvo-flow_1 | npm ERR!
akvo-flow_1 | npm ERR! Failed at the akvo-flow@ build:dev script.
akvo-flow_1 | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
akvo-flow_1 | npm WARN Local package.json exists, but node_modules missing, did you mean to install?

[dlebrero]

Do we want to run npm install and npm run in parallel? I understand that this is not new behavior but I am surprised nonetheless

[dlebrero]

How is this resolved? It is causing the issue described above.

[finnfiddle]

isnt it fixed now @dlebrero

[dlebrero]

It is not. Running npm install and npm run at the same time is causing the above issue.

[finnfiddle]

does this not run them sequentially?

npm install
npm run build:dev > "$SRC_DIR/build.dev.log" 2>&1 &

[dlebrero]

There is another Ruby file at https://github.com/akvo/akvo-flow/blob/20152ca7ce49033331ede4be3c6fddc42f4380e4/Dashboard/config/application.rb. Maybe it can also be removed

[stellanl]

Building this branch on my Linux machine (which has npm 3.5.2 installed) after clearing the target directory I get a number of npm warnings, but no error for /app/src/Dashboard:

akvo-flow_1_dbc781e50605 | Compiling "../../../GAE/target/akvo-flow/admin/frames/users.js" from ["src"]...
akvo-flow_1_dbc781e50605 | npm WARN @babel/[email protected] requires a peer of @babel/core@^7.0.0-0 but none is installed. You must install peer dependencies yourself.
akvo-flow_1_dbc781e50605 | npm WARN [email protected] requires a peer of @babel/core@^7.0.0 but none is installed. You must install peer dependencies yourself.
akvo-flow_1_dbc781e50605 | npm WARN [email protected] requires a peer of handlebars@>= 1.3.0 < 5 but none is installed. You must install peer dependencies yourself.
akvo-flow_1_dbc781e50605 | npm WARN akvo-flow@ No repository field.
akvo-flow_1_dbc781e50605 | npm WARN akvo-flow@ No license field.
akvo-flow_1_dbc781e50605 | npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
akvo-flow_1_dbc781e50605 | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
akvo-flow_1_dbc781e50605 | 
akvo-flow_1_dbc781e50605 | added 67 packages in 11.803s

[finnfiddle]

@dlebrero ok should be resolved now everything

[finnfiddle]

@dlebrero is this meant to be here?

[dlebrero]

No.