Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bootstrap-deploy.sh (connect #3017) #3023

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Update bootstrap-deploy.sh (connect #3017) #3023

merged 1 commit into from
Mar 21, 2019

Conversation

valllllll2000
Copy link
Contributor

@valllllll2000 valllllll2000 commented Mar 21, 2019 •
edited
Loading

Before the PR (what is the issue or what needed to be done)

broken builds due to missing NSS

The solution

add nss also to bootstrap-deploy.sh

Screenshots (if appropriate)

NA

Checklist

  • Connect the issue
  • Test plan
  • Copyright header
  • Code formatting
  • Documentation

@ghost ghost assigned valllllll2000 Mar 21, 2019
@ghost ghost added the In progress label Mar 21, 2019
stellanl
stellanl approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@stellanl stellanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@stellanl stellanl merged commit d905d3c into develop Mar 21, 2019
@ghost ghost removed the In progress label Mar 21, 2019
@stellanl stellanl deleted the issue/3017-broken-nss-deploy branch March 21, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellanl stellanl stellanl approved these changes

Assignees

@valllllll2000 valllllll2000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valllllll2000 @stellanl