Changing question type leads to incorrect data point name definition

[iperdomo]

Context

Changing the question type could lead to invalid question configuration.

Problem or idea

A user can set a question to be used as part of the "Datapoint name" by selecting the option Use as data point name

In this case the question type is "Text".

A geolocation question can be used to be the "Datapoint location" by selecting the option Use as data point location

If a user with a question type Text selects the option "Use as data point name" and then changes the question type to Geolocation and selects the option "Use as data point location" the question ends up with the 2 flags enabled.

When using the published form, the App user ends up with Data point names that contain the raw values of the Geolocation.

Solution or next step

• Make sure a Geolocation question can't be used as part of the data point name
• Whitelist the question types that can be used as data point name

[muloem]

This is a duplicate of #1692. Closing the other one.

[iperdomo]

Test case

• Create a question use Text as type, and select Use as data point name
• Save it
• Change the question type to Gelocation and select Use as data point location
• Save it
• The other flag Use as data point name must be de-selected
• Change it back again to Text and Use as data point name
• Save it
• The other flag Use as data point location must be de-selected

[iperdomo]

Attached a couple of executions on UAT1, before and after the fix: uat1.har.zip

.har files can be viewed on https://toolbox.googleapps.com/apps/har_analyzer/

• localeNameFlag can't be true if the question type is geolocation
• localeLocationFlag can't be true if the question type is not geolocation