Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignments - Small UI improvements #3285

Closed
janagombitova opened this issue Nov 8, 2019 · 5 comments
Closed

Assignments - Small UI improvements #3285

janagombitova opened this issue Nov 8, 2019 · 5 comments
Assignees
Milestone

Comments

@janagombitova
Copy link
Contributor

After our talk just now, @marvinkome can you add:

  • device counter
  • change 'No forms..' to 'No published forms...'

Screen Shot 2019-11-08 at 10.35.40.png

@muloem
Copy link
Member

muloem commented Nov 8, 2019

Another small issue here:

When selecting the group of devices, its possible to open up the group by clicking on the device group name. However, the rest of the section next to the device group name appears to be clickable but nothing happens when you click. same for the arrow at the extreme right end of the accordion.

assignments-ui-dropdown

marvinkome pushed a commit that referenced this issue Nov 8, 2019
@janagombitova
Copy link
Contributor Author

janagombitova commented Nov 8, 2019

And one more :)

66658010-e8d75900-ec40-11e9-9484-e968d02ceed1

I was looking at the mock-up and the form selector should not be checkboxes but radio buttons. So you turn a form on leave it turned off. Can you make the change? thanks

The reason why they are radio buttons and not checkboxes is because a checkbox indicates 'to select' but not 'to add', where a radion button (or toggle) does indicate that I am turning this one on. A stand alone checkbox is not strong enough because you select the item, but the question remains - to do what?. Thus can you change the checkboxes for forms to radio buttons (toggles).

We will keep the checkboxes for the devices for now, as they will remain as a way to select, but some more adjustments will happen in the next release when we push out the assigning data points to devices part.

@janagombitova janagombitova changed the title Assignments - 2 small UI improvements Assignments - Small UI improvements Nov 8, 2019
marvinkome pushed a commit that referenced this issue Nov 8, 2019
[#3285] - change no forms string. add device counter
@janagombitova
Copy link
Contributor Author

Hey Marvin, I had the feeling we had this already in an issue, but here I go again: Can you remove the text: Only enabled forms can be submitted? This is actually not correct in terms of how the assignments work

@janagombitova janagombitova added this to the 1.10.1 milestone Nov 8, 2019
@janagombitova
Copy link
Contributor Author

The remaining points will be handled in #3290

@muloem
Copy link
Member

muloem commented Nov 19, 2019

All done! 👍

@muloem muloem closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants