Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop updating dependencies to minor version #3257

Closed
marvinkome opened this issue Oct 23, 2019 · 1 comment
Closed

Stop updating dependencies to minor version #3257

marvinkome opened this issue Oct 23, 2019 · 1 comment
Assignees
@marvinkome
Labels
Legacy clean-up & Code Refactoring
Milestone
1.10.1

Comments

@marvinkome
Copy link
Contributor

During every new docker build package.lock.json file is updated in the Dashboard code. This is due to update in minor versions based on what's in the package.json file.

The solution will be to use fixed versions of libraries to avoid updates to package.lock file when running docker build.
@marvinkome marvinkome self-assigned this Oct 23, 2019
marvinkome pushed a commit that referenced this issue Oct 23, 2019
[#3257] - use fixed version of packages
9b7a15c
@muloem muloem added this to the 1.10.1 milestone Oct 23, 2019
marvinkome pushed a commit that referenced this issue Oct 25, 2019
Merge pull request #3258 from akvo/issue-3257/use-fixed-version-of-pa…
2562ba6 
…ckages

[#3257] - use fixed version of packages
@janagombitova
Copy link
Contributor

I assume there is nothing to test here. As the changes have been merged a while back I assume all work is done and the issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinkome marvinkome

Labels
Legacy clean-up & Code Refactoring
Projects
None yet
Milestone
1.10.1
Development

No branches or pull requests
3 participants
@muloem @janagombitova @marvinkome