Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse boolean options correctly #3252

Closed
stellanl opened this issue Oct 22, 2019 · 1 comment
Closed

Parse boolean options correctly #3252

stellanl opened this issue Oct 22, 2019 · 1 comment
Assignees
Milestone

Comments

@stellanl
Copy link
Contributor

stellanl commented Oct 22, 2019

In #2285 we switched checking of boolean options from String.equals() to String.equalsIgnoreCase() which uncovered an old bug. Boolean options are passed in from Clojure as Boolean, not String like other options.
The parameter of the export() method is defined as Map<String, String>, but this apparently is never checked/enforced, and so Java assumes everything in the map is String.

@stellanl stellanl self-assigned this Oct 22, 2019
stellanl added a commit that referenced this issue Oct 22, 2019
stellanl added a commit that referenced this issue Oct 22, 2019
stellanl added a commit that referenced this issue Oct 22, 2019
[#3252]Go via Object to avoid all compiler assumptions.
stellanl added a commit that referenced this issue Oct 22, 2019
stellanl added a commit that referenced this issue Oct 22, 2019
@janagombitova janagombitova added this to the 1.10.1 milestone Oct 25, 2019
@janagombitova
Copy link
Contributor

I assume there is nothing user visible to check here and that all work is done. So I am closing the issue. If it needs to be reopened please do so with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants