Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add number of selected devices in assignment UI #3232

Closed
marvinkome opened this issue Oct 15, 2019 · 3 comments
Closed

Add number of selected devices in assignment UI #3232

marvinkome opened this issue Oct 15, 2019 · 3 comments
Assignees
@marvinkome
Labels
1 - Assignment
Milestone
1.10.1

Comments

@marvinkome
Copy link
Contributor

Add the number of selected devices as indicated in the mock-up below

image
@marvinkome marvinkome self-assigned this Oct 15, 2019
@janagombitova janagombitova added this to the 1.10.1 milestone Oct 15, 2019
@marvinkome
Copy link
Contributor Author

image

With the current implementation, if you click the checkbox the accordion will open or close. I'm suggesting i make only the Device name clickable, but with this, if you click the space nothing will happen too. What do you think @janagombitova @Kiarii

@Kiarii
Copy link

Kiarii commented Oct 16, 2019

@marvinkome thats a good point, the checkbox should only enable selection. In addition we should use caret down and up icons in place of a [+] and [-] for indicating expanding and collapsing of accordion items so as not to confuse the users into wondering whether [+], [-] adds or removes devices..

marvinkome pushed a commit that referenced this issue Oct 17, 2019
[#3232] - show number of selected devices
36243c8
marvinkome pushed a commit that referenced this issue Oct 25, 2019
[#3232] - use destructuring when getting no. selected devices
a6b554b
marvinkome pushed a commit that referenced this issue Oct 25, 2019
[#3232] - add translation strings
2ec828b
marvinkome pushed a commit that referenced this issue Oct 25, 2019
[#3232] - move translation to ember side
425ee21
marvinkome pushed a commit that referenced this issue Oct 25, 2019
[#3232] - merge with develop
2d7a310
marvinkome pushed a commit that referenced this issue Oct 25, 2019
Merge pull request #3239 from akvo/issue-3232/show-number-of-selected…
f1743af 
…-devices

[#3232] show number of selected devices
@janagombitova
Copy link
Contributor

Works well on UAT2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinkome marvinkome

Labels
1 - Assignment
Projects
None yet
Milestone
1.10.1
Development

No branches or pull requests
3 participants
@janagombitova @Kiarii @marvinkome