Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for assignments ui move to react #3212

Closed
marvinkome opened this issue Sep 30, 2019 · 4 comments
Closed

Tests for assignments ui move to react #3212

marvinkome opened this issue Sep 30, 2019 · 4 comments
Assignees
@marvinkome
Milestone
1.10.1

Comments

@marvinkome
Copy link
Contributor

Create UI tests for assignments UI component
@marvinkome marvinkome self-assigned this Sep 30, 2019
marvinkome pushed a commit that referenced this issue Sep 30, 2019
[#3212] - update device selector tests
93cc610
marvinkome pushed a commit that referenced this issue Oct 2, 2019
[#3212] - add prettier to eslint
986b6dc
marvinkome pushed a commit that referenced this issue Oct 2, 2019
[#3212] - fix merge conflict
d6e77fb
marvinkome pushed a commit that referenced this issue Oct 4, 2019
[#3212] - update tests to match new refactor
1c2200e
marvinkome pushed a commit that referenced this issue Oct 4, 2019
[#3212] - fix folder selector tests
de87aaa
marvinkome pushed a commit that referenced this issue Oct 4, 2019
[#3212] - write tests for form selector
37d1620
marvinkome pushed a commit that referenced this issue Oct 10, 2019
Merge pull request #3214 from akvo/issue/3212-fix-device-selector-tests
62dc65f 
[#3212] - update device selector tests
marvinkome pushed a commit that referenced this issue Oct 10, 2019
Merge pull request #3218 from akvo/issue/3212-fix-folder-selector-tests
0f2a220 
[#3212] - fix folder selector tests
@janagombitova
Copy link
Contributor

@marvinkome is the work here done? Can we close the issue?

@janagombitova janagombitova mentioned this issue Oct 18, 2019
Merged
5 tasks
@janagombitova
Copy link
Contributor

It seems that pull request #3212 that is linked to this issue has not been merged yet. So I am moving the issue to the next milestone. Let's make sure the PRs get merged asap.

marvinkome pushed a commit that referenced this issue Oct 24, 2019
Merge pull request #3219 from akvo/issue/3212-form-selector-tests
e5df72f 
[#3212] - form selector tests
@janagombitova
Copy link
Contributor

I guess there is nothing user visible to test here. @marvinkome if you are all done with these tests and everything is reviewed and merged, please close the issue. If not, comment so we know where we stand. Thanks

@muloem
Copy link
Member

muloem commented Nov 19, 2019

All done! 👍

@muloem muloem closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinkome marvinkome

Labels
None yet
Projects
None yet
Milestone
1.10.1
Development

No branches or pull requests
3 participants
@muloem @janagombitova @marvinkome