Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /surveyedlocale endpoint to enable datapoint filtering #3167

Closed
muloem opened this issue Aug 21, 2019 · 3 comments
Closed

Update /surveyedlocale endpoint to enable datapoint filtering #3167

muloem opened this issue Aug 21, 2019 · 3 comments

Comments

@muloem
Copy link
Member

muloem commented Aug 21, 2019

As part of the updates to the assignments (see #2796) that enable selecting specific datapoints to assign them to devices (#3166), we need to modify the endpoint used by devices to download datapoints, to enable it filter out and only return datapoints assigned to a specific device.

Some issues to consider:

  • If we return such a filtered list, would it be processed without any problems by devices with current versions of the app?
@stellanl
Copy link
Contributor

stellanl commented Sep 9, 2019

To avoid backwards-compatibility problems we decided to add a new endpoint, /datapoints that will return only the data points (surveyedLocales) the device has been assigned. It generally uses the same parameters as /surveyedlocale.

Old apps continue to use the old endpoint and get all data points as before.

stellanl added a commit that referenced this issue Sep 9, 2019
@stellanl stellanl assigned stellanl and unassigned valllllll2000 Sep 9, 2019
stellanl added a commit that referenced this issue Sep 19, 2019
stellanl added a commit that referenced this issue Sep 23, 2019
stellanl added a commit that referenced this issue Oct 1, 2019
stellanl added a commit that referenced this issue Oct 1, 2019
Issue/3167 filter app datapoints (Connect #3167)
@janagombitova
Copy link
Contributor

I guess there is nothing user-facing to test for this specific issue for now, right? Is this change on UAT1? Can we close the issue?

@janagombitova
Copy link
Contributor

All linked PRs are merged and released. If this still needs work - please reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants