Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to babel v7 #3162

Closed
muloem opened this issue Aug 15, 2019 · 2 comments
Closed

Upgrade to babel v7 #3162

muloem opened this issue Aug 15, 2019 · 2 comments
Assignees
@muloem
Labels
Deployment & infrastructure
Milestone
1.10 Worshipped W...

Comments

@muloem
Copy link
Member

muloem commented Aug 15, 2019

We need to upgrade babel to correctly transpile the newer ES6 class syntax
@muloem muloem added this to the 1.9.50 W... W... milestone Aug 15, 2019
@muloem muloem self-assigned this Aug 15, 2019
muloem added a commit that referenced this issue Aug 16, 2019
@muloem
[#3162] Upgraded to babel v7 using babel-upgrade tool
5a9bf0e
muloem added a commit that referenced this issue Aug 16, 2019
@muloem
[#3162] Remove packages that cause babel to break while transpiling
a3b4cd7 
* Remove react-hmre presets
* Move prop-types dependency to dev dependency
* Move handlebars to dev dependency
* Remove unneeded tar dependency
muloem added a commit that referenced this issue Aug 16, 2019
@muloem
[#3162] Restore missing prop-types dependency
8955a26
muloem added a commit that referenced this issue Aug 16, 2019
@muloem
[#3162] Upgrade security warning packages
c5aeaae
@muloem
Copy link
Member Author

muloem commented Aug 16, 2019

Test Plan

Should be covered under regression testing. The UI should generate and behave as always.

kymni pushed a commit that referenced this issue Aug 18, 2019
Merge pull request #3165 from akvo/issue/3162-babel-upgrade
dc2e061 
[#3162] Babel upgrade to enable build react class components
@janagombitova
Copy link
Contributor

Nothing major found. Will create a separate issue if so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muloem muloem

Labels
Deployment & infrastructure
Projects
None yet
Milestone
1.10 Worshipped Wolfbane
Development

No branches or pull requests
2 participants
@muloem @janagombitova