Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop unnecessary loading of all Surveys once forms are loaded #3139

Closed
muloem opened this issue Jul 18, 2019 · 1 comment
Closed

Stop unnecessary loading of all Surveys once forms are loaded #3139

muloem opened this issue Jul 18, 2019 · 1 comment

Comments

@muloem
Copy link
Member

muloem commented Jul 18, 2019

After all forms are loaded, an observer then proceeds to request all the related Surveys for these forms one-by-one even though the surveys have already been loaded through a bulk request. This increases the overall loading time of the dashboard and is unnecessary because the purpose of the loading is to fill a property surveyGroupName that is only used under the assignments tab.

Proposal is to stop this loading of all Surveys and to use a computer property for the surveyGroupName.

@muloem muloem added this to the 1.9.49 V... V... milestone Jul 18, 2019
@muloem muloem changed the title All Surveys are loaded one by one after loading forms Stop unnecessary loading of all Surveys once forms are loaded Jul 18, 2019
@muloem muloem self-assigned this Jul 18, 2019
muloem added a commit that referenced this issue Jul 19, 2019
* We also dont need to check the ancestorIds as its enough to check for the parent survey of the form.
@muloem
Copy link
Member Author

muloem commented Aug 1, 2019

Test Plan

The changes affect the survey assignment and the offline assignment UI. These should behave the same as before, i.e. the survey should correctly show next to the form name.

@muloem muloem closed this as completed Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant