Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignments form selector #3136

Closed
muloem opened this issue Jul 13, 2019 · 3 comments
Closed

Assignments form selector #3136

muloem opened this issue Jul 13, 2019 · 3 comments

Comments

@muloem
Copy link
Member

muloem commented Jul 13, 2019

In order to select a particular form to be included in the list of forms enabled for an assignment, we implement the form selector/enabler component. From this component we populate the list of forms that are included in an assignment to a device.

Screenshot 2019-07-13 at 16 55 29

@muloem muloem added this to the 1.9.49 V... V... milestone Jul 13, 2019
@janagombitova
Copy link
Contributor

@kymni Charles, can you check the revised mockup here, please? Thanks. #3137 (comment)

kymni pushed a commit that referenced this issue Sep 5, 2019
kymni pushed a commit that referenced this issue Sep 5, 2019
kymni pushed a commit that referenced this issue Sep 5, 2019
kymni pushed a commit that referenced this issue Sep 6, 2019
valllllll2000 pushed a commit that referenced this issue Sep 9, 2019
kymni added a commit that referenced this issue Sep 26, 2019
…ndpoint changed to formIds and deviceIds respectively
@janagombitova janagombitova assigned marvinkome and unassigned kymni Oct 11, 2019
@janagombitova
Copy link
Contributor

Everything works as expected. But there is quite some duplication in this UI.

Screen Shot 2019-10-11 at 08 41 53

@marvinkome can we make the following changes:

  • remove change the title to '2. Survey and forms'
  • if possible remove the '0.1' and '03.' from all the three headers
  • move the survey dropdown right under the header
  • remove the heading above the dropdown as within the dropdown we already state Choose a folder or a survey
  • under the dropdown change 'Select forms:' to only 'Forms' as indicated in the mock-up above
  • under the 'Forms' title add 'Only published forms are shown in this list' (as we have with the 'Can't find your survey? Perhaps it has not been published yet. Only published surveys are shown in this list.' --> but this text should be fully removed as it is not 100% correct)

@janagombitova
Copy link
Contributor

As @marvinkome creates a separate issue for the last improvements #3227 I am closing this one so avoid duplication of issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants