Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure new Data Point identifiers are 14 chars long #3117

Closed
stellanl opened this issue Jun 13, 2019 · 0 comments
Closed

Ensure new Data Point identifiers are 14 chars long #3117

stellanl opened this issue Jun 13, 2019 · 0 comments
Assignees
@stellanl
Milestone
1.9.48 Unique Urs...

Comments

@stellanl
Copy link
Contributor

stellanl commented Jun 13, 2019 •
edited
Loading

When a data point identifier/UID is generated by com.gallatinsystems.surveyal.domain.SurveyedLocale.generateBase32Uuid(), there is a risk of it being truncated, ending up as abcd-efgh-jkm (or even shorter). This occurs if the number has one or more leading zeroes when converted to base-32, so stastically it happened for 1/32 identifiers.
@stellanl stellanl self-assigned this Jun 13, 2019
@stellanl stellanl changed the title Ensure Data Point UIDs are 14 chars long Ensure new Data Point identifiers are 14 chars long Jun 14, 2019
stellanl added a commit that referenced this issue Jun 20, 2019
@stellanl
[#3117]Reinstate suppressed leading zeroes.
abc8fb4
stellanl added a commit that referenced this issue Jun 20, 2019
@stellanl
[#3117]Remove unused import.
49506fe
@valllllll2000 valllllll2000 mentioned this issue Jun 20, 2019
Closed
valllllll2000 pushed a commit that referenced this issue Jun 24, 2019
Merge pull request #3122 from akvo/issue/3117-fix-abbreviated-identif…
089ca68 
…iers

[#3117]Reinstate suppressed leading zeroes.
@muloem muloem added this to the 1.9.48 Unique Ursinia milestone Jul 13, 2019
@muloem muloem closed this as completed Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stellanl stellanl

Labels
None yet
Projects
None yet
Milestone
1.9.48 Unique Ursinia
Development

No branches or pull requests
2 participants
@stellanl @muloem