Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caddisfly data not exported properly; uses old test definitions file. #3077

Closed
stellanl opened this issue Apr 25, 2019 · 3 comments
Closed

Caddisfly data not exported properly; uses old test definitions file. #3077

stellanl opened this issue Apr 25, 2019 · 3 comments
Assignees
@stellanl
Labels
2 - Caddisfly
Milestone
1.9.46 Squishy Sq...

Comments

@stellanl
Copy link
Contributor

Some questions do not even get columns. May be related to #1931, which is high time to address anyway.
@stellanl stellanl self-assigned this Apr 25, 2019
@stellanl
Copy link
Contributor Author

Not related to the all-repeat problem. Happens after that was fixed. Header generation is the primary focus.

@stellanl
Copy link
Contributor Author

This is actually working as designed. The responses in question either did not have a test definition, or were specified as requiring an image, which was missing. Maybe we should add a sheet with errors or counters for strange but not fatal things about the export?

@stellanl
Copy link
Contributor Author

stellanl commented Apr 25, 2019 •
edited
Loading

Seems this is because there is a new test definitions file, https://akvoflow-public.s3.amazonaws.com/caddisfly-tests-v2.json, see issue #2842.

@stellanl stellanl reopened this Apr 25, 2019
@stellanl stellanl changed the title Caddisfly data not exported properly Caddisfly data not exported properly; uses wrong test definitions file. Apr 25, 2019
@stellanl stellanl changed the title Caddisfly data not exported properly; uses wrong test definitions file. Caddisfly data not exported properly; uses old test definitions file. Apr 25, 2019
stellanl added a commit that referenced this issue Apr 25, 2019
@stellanl
[#3077]Use new test definitions file. Handle nulls for hasImage.
1e8ab96
muloem added a commit that referenced this issue Apr 26, 2019
@muloem
Merge pull request #3078 from akvo/issue/3077-use-new-caddisfly-test-…
24b0ec8 
…definitions

[#3077] Use new test definitions file. Handle nulls for hasImage.
@muloem muloem added this to the 1.9.45 S... S... milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stellanl stellanl

Labels
2 - Caddisfly
Projects
None yet
Milestone
1.9.46 Squishy Squash
Development

No branches or pull requests
3 participants
@stellanl @muloem @janagombitova