Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports broken if first/all groups repeatable, or if there is >100 repeats #3020

Closed
stellanl opened this issue Mar 20, 2019 · 5 comments
Closed
Assignees

Comments

@stellanl
Copy link
Contributor

stellanl commented Mar 20, 2019

DC report data points are supposed to begin on row 3, but begin on row 2, same as for the other exports. But on the base sheet ("raw data") the DC export has one more header row, which somehow overwrites the first row of data. Seen with a form where group 1 was repeatable, and group 2 was not (and had no data) using dashboard v1.9.44 and app v2.7.2

@stellanl
Copy link
Contributor Author

Likely related to #2995. Surveys with 1st group repeatable were never tested when repeatable groups moved to separate sheets.

@stellanl stellanl self-assigned this Apr 15, 2019
@stellanl
Copy link
Contributor Author

There is another bug here, too; if a form instance has more than 100 repeats, both the metadata headers and the md5 sum is only correct for the last 100 (those that are in the Excel file access window).

@stellanl
Copy link
Contributor Author

@stellanl
Copy link
Contributor Author

stellanl commented Apr 16, 2019

Test plan:

  1. Create a data cleaning report for a form with all groups repeatable, and at least one instance with more than 100 repeats, such as akvoflow-122, Form "Cambodia > CHAIN > CHAIN2 Farmer Progress Monitoring > Farmer Progress Monitoring 030319 > 2 - Harvested crops", 350260004
  2. Check that there are no answers on the base sheet, but metadata and a message digest for each instance.
  3. Check on the group sheet that there are no metadata or data gaps at the beginning of an instance with >100 repeats.

@janagombitova
Copy link
Contributor

@stellanl I noticed the PR was merged. Is this issue then resolved and in production or does more still need to happen?

@stellanl stellanl changed the title Data cleaning export starts one line too high Exports broken if all groups repeatable, or if there is >100 repeats May 6, 2019
@stellanl stellanl changed the title Exports broken if all groups repeatable, or if there is >100 repeats Exports broken if first/all groups repeatable, or if there is >100 repeats May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants