Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Data cleaning UI to match export changes #2300

Closed
janagombitova opened this issue Nov 7, 2017 · 8 comments
Closed

Simplify Data cleaning UI to match export changes #2300

janagombitova opened this issue Nov 7, 2017 · 8 comments

Comments

@janagombitova
Copy link
Contributor

Context

We have started a larger project on improving how users export data, how we divide export types, call them and structure the UI. In this issue you can find all details: akvo/akvo-product-design#273 Because exporting data is in Flow closely linked to importing data and data cleaning, we need to make sure the Data cleaning tab matches with the changes coming.

We recognised that Data cleaning needs larger improvements in regards to the UI, but mostly around notifying the user if import or export went wrong and why. As these changes are not defined nor tested yet, we will only change the current UI with some lipstick improvements to bring consistency.

Current UI

screen shot 2017-11-07 at 09 16 49

Changes

  • change ‘Export raw data report’ title to ‘Data cleaning export’
  • shorten the description and only keep: ‘Please make a copy of this file before you make any changes.’
  • change button from 'Raw data report' to 'Download'
  • change: ‘Import cleaned survey data’ to ‘Import data’
  • shorten description to only ‘Import will overwrite the existing data. The file must be in .xlsx or .xls format.
  • change button from 'Import clean data' to 'Import'
@Maseline
Copy link
Contributor

Maseline commented Nov 8, 2017

@janagombitova Export raw data report and and the length description are present under Reports as well, should i implement a change that works to change the text for both Data Cleaning and Reports or just for this case of Data Cleaning

@janagombitova
Copy link
Contributor Author

@Maseline Good catch! Only on the Data cleaning page as we are implementing a fully new UI (Loic is currently working on that with Stellan) for the Reports. Here you can see what is coming up: #2282

@Maseline
Copy link
Contributor

Maseline commented Nov 8, 2017

Test plan
Select Data from the main navigation
Under Data select Data Cleaning
Note that the headings, descriptions and button text have changed
Note that these changes have not affected what was under Reports

@janagombitova
Copy link
Contributor Author

janagombitova commented Nov 24, 2017

Note sure if what I see is due to these changes, but something broke on the Data cleaning tab and needs fixing. The folder/survey/form dropdowns are gone and I cannot select a form to work with:

screen shot 2017-11-24 at 10 27 06
screen shot 2017-11-24 at 10 27 17
screen shot 2017-11-24 at 10 26 51

Secondly, when selecting the date in Collected from and to I do not get the date selector anymore:

screen shot 2017-11-24 at 10 29 09

@Maseline
Copy link
Contributor

Seems unlikely since only changes made were to placeholders text but let me look into it

@janagombitova
Copy link
Contributor Author

Thank you and please do not forget the date selector that should be showing.

screen shot 2017-11-24 at 12 10 51

@muloem
Copy link
Member

muloem commented Nov 24, 2017

The issue with the inspect data tab not loading is connected to changes in #2282. Specifically the changes in views.js under a962f53

@janagombitova
Copy link
Contributor Author

All resolved 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants