Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long names break cascade layout - in levels #2266

Closed
janagombitova opened this issue Sep 26, 2017 · 2 comments
Closed

Long names break cascade layout - in levels #2266

janagombitova opened this issue Sep 26, 2017 · 2 comments
Assignees
Milestone

Comments

@janagombitova
Copy link
Contributor

janagombitova commented Sep 26, 2017

Since the design improvements introduced in this issue: #2033 some already existing cascade UI issues resurfaced. Here is one of them:

Context

The use of cascades has expanded from just using it to select administrative areas to using it for scoring. This shift in use results also in the level names not holding short one word text, as District or County, but actual questions and sentences.

The current design does not support long level names.

Problem

If the cascade level name is too long is breaks the layout in multiple places:

  • in the top of the cascade editor, if the level names are too long, or there are too many levels they overlap with the Add level button which is then hard to find in the screen.
  • In the level itself you loose the button to edit the name
  • This then results in the add, edit and delete clickable links for the options of the level to be out of range as well (see 2nd image)

screen shot 2017-09-26 at 12 20 27

screen shot 2017-09-26 at 12 17 36

screen shot 2017-09-26 at 12 18 27

Next steps

With this issue we do not need to introduce a large redesign of how cascades are created a that is a large endeavour, but we should aim to resolve (if possible) the above mentioned issue in the current structure

loicsans added a commit that referenced this issue Sep 27, 2017
As well as level name editing missing actions.
@janagombitova
Copy link
Contributor Author

@loicsans Hey Loic, I just checked the changes on glimmerofhope and if there is a long name in the level of the cascade, it looks ok on the level arrows where the name does not show fully, but there are a few issues still pending:

  • on the level arrows the "add level" button still overlaps (circled in the 1st image)
  • when editing the levels, in the level, you get that odd long scrolling to the side (see gif)

screen shot 2017-10-06 at 12 08 21

2

Note: the colour changes are not shown as only this branch is deployed to flowaglimmerofhope. They are, however, already merged and ready for release

@janagombitova janagombitova added this to the 1.9.25 Y... Y... milestone Nov 1, 2017
@janagombitova janagombitova removed this from the 1.9.25 Yetanother Yak milestone Nov 23, 2017
@janagombitova janagombitova added this to the 1.10.1 milestone Oct 27, 2019
@janagombitova
Copy link
Contributor Author

The core is fixed but still more to improve overall. Another issue, another time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants