Question IDs - simplify validation

[janagombitova]

Current implementation

When creating a question ID we validate two things: the format, uniqueness.

If the input does not pass the validation we show in red the info above the text field. The user can hit Save, to save the question, but he will receive a modal dialogue telling him the same info as the red error message. He needs to confirm, what brings him back to the question. He cannot save the question until he makes adjustments to the ID

Validation error messages

Modal dialogues after trying to save the question

If the user hits Cancel, then the ID is not saved.

Improvement

Would it be possible to instead of showing that the ID format is not correct, being able to click on save and getting the pop up message, to simply validate the field (as we do) and disable the save button, removing the modal dialogues?

Secondly, the text for the uniqueness validation needs to be improved:
Current text: the question id is not unique
New text:

• option A: Question ID is not unique
• option B: Question ID already exists
• option C: ... to be defined ...

@muloem and @kymni what are your thoughts?

[janagombitova]

Before we make any improvements to the validation of the question IDs we need to agree on if we change how we call this feature: #2170

[kymni]

#2170 remains open, what's the way forward for this?

[janagombitova]

My suggestion would be to 1st handle #2170 so move away from Question ID and implement Variable name throughout all Flow components and then handle this issue by disabling Save if the Variable name is not correct and simplify the validation notes.

[janagombitova]

@kymni I have noticed one small detail that need to be improved before this can go live: if the variable name is not unique, the current error message says: Variable name not unique. Can you please change it to: Variable name is not unique

[kymni]

Slightly related but current in current implementation, the error message is hard-coded. I'll create a separate issue to change this so that error message is pulled from transifex while at the same time implementing your change request

[janagombitova]

Perfect, thanks @kymni. This one is then ready to roll 👍