Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving folder onto itself (estimated: 4) #1367

Closed
jonase opened this issue Jul 30, 2015 · 4 comments
Closed

Moving folder onto itself (estimated: 4) #1367

jonase opened this issue Jul 30, 2015 · 4 comments
Assignees

Comments

@jonase
Copy link
Contributor

jonase commented Jul 30, 2015

It's currently possible to move a folder onto itself (or some folder further down the hierarchy). This will result in a situation where the parentId path introduces a loop and never reaches the root folder. Immediate result of this is that the folder dissappears from the dashboard.

We should make sure that this is not a possibility:

  • Disable the target folder <a> tag so it's not possible to navigate into the target folder
  • Possibly add a check on the backend
muloem added a commit that referenced this issue Jul 30, 2015
@rumca rumca added this to the 1.9.0 milestone Aug 11, 2015
@muloem muloem modified the milestones: 1.9.1, 1.9.0 Aug 13, 2015
@muloem
Copy link
Member

muloem commented Aug 13, 2015

@rumca the script for checking for folders has been created but we also need to include a fix to prevent this from happening. Thats why I moved it to the next release.

@rumca
Copy link
Contributor

rumca commented Aug 13, 2015

👍

@rumca rumca modified the milestones: 1.9.2, 1.9.1 Sep 30, 2015
@rumca rumca modified the milestones: 1.9.3, 1.9.2 Oct 27, 2015
@GeertSoet
Copy link

Assigned to Tender discussion #6247.

@rumca rumca modified the milestones: 1.9.4, 1.9.3 Nov 22, 2015
@muloem muloem modified the milestones: 1.9.4, 1.9.5 Dec 30, 2015
@rumca rumca modified the milestones: 1.9.6, 1.9.5 Feb 22, 2016
@rumca rumca modified the milestones: 1.9.7, 1.9.6 Apr 4, 2016
@muloem muloem modified the milestones: 1.9.8, 1.9.7 Apr 8, 2016
@janagombitova janagombitova changed the title Moving folder onto itself Moving folder onto itself (estimated: 6) May 11, 2016
@janagombitova janagombitova changed the title Moving folder onto itself (estimated: 6) Moving folder onto itself (estimated: 4) May 11, 2016
@janagombitova janagombitova removed this from the 1.9.10 milestone Aug 12, 2016
@janagombitova janagombitova modified the milestones: 1.9.11, 1.9.12 Sep 16, 2016
@janagombitova janagombitova modified the milestones: 1.9.11a, 1.9.11 Sep 26, 2016
@janagombitova janagombitova modified the milestones: 1.9.12, 1.9.11 Nov 2, 2016
@muloem muloem modified the milestone: 1.9.12 Jan 10, 2017
muloem added a commit that referenced this issue Oct 5, 2017
…tself

[#1367] Do not open folder being moved. Fix spelling. (Connect #1367)
@janagombitova
Copy link
Contributor

So I tried to move the folder on itself and tried and tried and could not. But I could move it somewhere else, so all good 👍 Ready to get out there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants