-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: replace detect_ids
with detect
#653
Conversation
- add deprecation warning for 'detect_ids' - support new 'detect' in place of 'detect_ids'
- update use cases yaml files to use 'detect'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments for your consideration
Edit: I realized detect_ids
is referenced in use cases (such as face_mask_detection) and in the yolo_face
model, I think those should be changed to detect
as well
…e of 'detect_ids' - update declarative_loader to use 'deprecate' for 'detect_ids' deprecation notice - update declarative_loader to perform class names to id conversion if model is not yolo_face
Also updated |
Changes:
detect_ids
withdetect
so as to be more user-friendlydetect_ids: ["dog"]
, it is nowdetect: ["dog"]
detect_ids
in object detection models (efficientdet, yolo, yolox) configsdetect
in place ofdetect_ids
detect_ids
.Technotes:
peekingduck/pipeline/nodes/model
level, within the__init__
of EfficientDet, Yolo and YoloX, relevant code shown below:self.detect_ids
.detect
is used at the user-interface level.