-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default build version from ia32 to x64 #987
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe configuration update modifies the Electron Builder settings in the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
vue.config.js (1)
29-29
: Architecture change from ia32 to x64 could impact compatibility.The change from 32-bit (ia32) to 64-bit (x64) architecture for the Windows build target means the application will no longer be compatible with 32-bit Windows systems. While this aligns with modern standards as most systems today are 64-bit, consider the following:
- Does your user base include anyone still using 32-bit Windows systems?
- Have you clearly communicated this change to users?
- Consider documenting updated system requirements mentioning 64-bit Windows is now required.
The change will likely improve performance for users on 64-bit systems by allowing the application to use more memory and leverage 64-bit optimizations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the default build configuration in vue.config.js to change the target architecture from ia32 to x64 for modern Windows systems.
- Updated NSIS target configuration to support only 64-bit installations.
- Modified the build command configuration for enhanced flexibility.
Update vue.config.js
Change the default build version from ia32 to x64.
Summary by CodeRabbit