forked from FreeRTOS/FreeRTOS
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conflicting definition of SdkLog from config files #1
Open
aggarw13
wants to merge
14
commits into
master
Choose a base branch
from
fix/conflicting-defining-of-sdk-log
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update logging_stack.h file to avoid use of __FUNCTION__ macro * Revert to use __FUNCTION__ instead of __FILE__ * Fix comment about metadata format * Fix incorrect mapping of SdkLog function * Fix typo causing LOG_METADATA_ARGS to be undefined * Fix another bug with SdkLog macro definition * Fix formatting * Move mapping of SdkLog to vLoggingPrintf from logging_stack to config files * Remove dependency of LIBRARY_LOG_NAME on LIBRARY_METADATA_* macros * Minor improvements Co-authored-by: Gary Wicker <[email protected]> Co-authored-by: RichardBarry <[email protected]>
* Fix logging stack to print message in the first SdkLog * Do not log metadata if on the same line * Fix wrong var name * Change task names to DemoTask * Change for shadow too * Move declaration to a separate line Co-authored-by: Gary Wicker <[email protected]>
* URLs have changed on the FreeRTOS.org site - this commit matches the URLs in the code with the new URLs on the website. * Add link to device shadow directory to the shadow docs. * Update main.c * Update main.c * Update readme.txt * Update main.c * Update main.c * Update readme.txt Co-authored-by: yngki <[email protected]>
* Add submodule pointer to the aws/jobs-for-aws-iot-embedded-sdk repository for the Jobs library * Commonize the MQTT helper functions used by the Device Shadow demo by re-locating them to FreeRTOS-Plus/Demo/AWS/MQTT_Demo_Helpers and updating the Device Shadow demo to use the new files
* Add Makefile project for RISC-V QEMU virtpc This patch adds simple demo directory for QEMU virtpc machine. A demo just prints Tx/Rx message of queue to serial port, use no other hardware and use only primary core (currently hart0). Other cores are simply going to wfi state and execute nothing else. Example command is: qemu-system-riscv32 -nographic -machine virt -net none \ -chardev stdio,id=con,mux=on -serial chardev:con \ -mon chardev=con,mode=readline -bios none \ -kernel demo.elf -smp cpus=2 -s * Fix copyright and URLS of FreeRTOS * Fix Makefile * Add Readme.md * Separate blinky demo from main code Co-authored-by: alfred gedeon <[email protected]> Co-authored-by: Cobus van Eeden <[email protected]> Co-authored-by: Carl Lundin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem \n When there are different definitions of
SdkLog
in different config files (likedemo_config.h
andcore_mqtt_config.h
files) and the config files are included in the same translation unit, there is compiler warning of conflicting definitions. \n #### Fix \n Add#ifndef
guards around theSdkLog
definitions in config files to avoid multiple definitions in a translation unit. \n #### Note For most cases, the user may need to define theSdkLog
macro ONLY once for the entire project build. An alternative way to define the macro for the whole project is by setting its default value in theFreeRTOS-Plus/Source/Utilities/Logging/logging_stack.h
file