Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openjdk tests rerun target guide #6096

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

LongyuZhang
Copy link
Contributor

Add openjdk tests rerun target guide.

Issue: #6091 (comment)

@LongyuZhang LongyuZhang requested a review from llxia March 24, 2025 19:59
@@ -137,7 +137,7 @@ Download any artifacts you need from your run as soon as it finishes to attach t
- When reporting failures in issues, understand that Grinder jobs are transient (not kept for long on Jenkins).
Sharing a link to the Grinder is only useful for a short time.
Share the "Rerun in Grinder" link which has details of the impl/version/test target, output statistics & test artifacts in the issue; those are more concrete items when reproducing failures.
For openjdk test failures, here are some useful triage [instructions](https://github.com/adoptium/aqa-tests/wiki/Guidance-for-Creating-OpenJDK-Test-Defects).
For openjdk test failures, here are some useful triage [instructions](https://github.com/adoptium/aqa-tests/wiki/Guidance-for-Creating-OpenJDK-Test-Defects). Rerun failed openjdk subtest function is also available, and the rerun target name depends on the failed test name, e.g. `jdk_math` rerun subtest uses test target `jdk_custom` and failed subtest name(s), while `hotspot_compiler` uses `hotspot_custom` instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add

For openjdk, the test target name starts with `jdk_` would be set into auto-rerun target `jdk_custom`. Otherwise, it would be set into auto-rerun target `hotspot_custom`. 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks.

Add openjdk tests rerun target guide

Signed-off-by: LongyuZhang <[email protected]>
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from smlambert March 24, 2025 21:03
@karianna karianna merged commit 90a80bc into adoptium:master Mar 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants