Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Fetch OTP release based on ImageOS environment variable #46

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Fetch OTP release based on ImageOS environment variable #46

merged 4 commits into from
Nov 17, 2020

Conversation

deniskulicek
Copy link
Contributor

@deniskulicek deniskulicek commented Oct 28, 2020

Once hexpm/bob#68 is merged we'll probably want to fetch correct OTP build based on the vm running the action.

Obviously the checks will be failing until bob the builder builds those OTP versions.

@ericmj
Copy link
Contributor

ericmj commented Oct 28, 2020

hexpm/bob#68 has been merged. The images will start to build and should all be available in less than 24 hours (hopefully). Keep in mind that all images have not yet been fully tested and should therefor be considered experimental. Maybe we should make this opt-in behind a config until we have determined they are good?

@deniskulicek
Copy link
Contributor Author

@ericmj sounds good to me. Any implementation suggestions? I’d add input variable for opting in, otherwise default to “ubuntu-14.04”

@ericmj
Copy link
Contributor

ericmj commented Oct 28, 2020

Maybe a new opt-in config such as experimental-otp: true could be used. In the future, when the new builds are deemed stable we would ignore this config.

@deniskulicek
Copy link
Contributor Author

@ericmj input flag experimental-otp is now added. Unless the flag is provided, we keep using ubuntu-14.04, otherwise one of ubuntu-16.04, ubuntu-18.04 or ubuntu-20.04 is used - based on runner ImageOS version. Please check it out and let me know if there is anything missing.

@ericmj
Copy link
Contributor

ericmj commented Oct 29, 2020

The builds have completed and are now available for all Ubuntu LTS versions.

Please check it out and let me know if there is anything missing.

Everything looks good to me but @jclem has the final say of course.

@jclem
Copy link
Contributor

jclem commented Nov 17, 2020

Sorry for the delay here—this looks great.

@jclem jclem merged commit 96441ef into actions:main Nov 17, 2020
@deniskulicek deniskulicek deleted the parametrize-otp-os-version branch November 17, 2020 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants