Use a dedicated helper to check current controller action in views #1425 #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MontrealSergiy
changed the title
prioux
requested changes
Mar 3, 2025
I guess I got confused should PR go to dev or master. I switched it to master, which seems to be the current policy, so irrelevant staff does not show now. Should I still do something else? |
prioux
reviewed
Mar 4, 2025
prioux
reviewed
Mar 4, 2025
prioux
reviewed
Mar 5, 2025
BrainPortal/app/views/layouts/_neurohub_secondary_navbar.html.erb
Outdated
Show resolved
Hide resolved
prioux
requested changes
Mar 5, 2025
|
There is now a conflict because this PR changes one line in data_providers/new.html.erb that was also modified by a PR merged yesterday! Just fix manually please so we can merge. |
|
fixing, not sure did it work, will check in a min |
|
I think it worked. I'll merge the PR once the tests have finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor action checking.
for details see #1425
a separate commit contains few simplifications of the related NeuroHub code