Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise task binding of local provider folders #1401

Merged
merged 11 commits into from
Mar 10, 2025
Merged

Optimise task binding of local provider folders #1401

merged 11 commits into from
Mar 10, 2025

Conversation

MontrealSergiy
Copy link
Contributor

No description provided.

@MontrealSergiy MontrealSergiy added Enhancement Boutiques Boutiques integration labels Jul 2, 2024
@MontrealSergiy MontrealSergiy self-assigned this Jul 2, 2024
@MontrealSergiy MontrealSergiy changed the base branch from master to dev July 2, 2024 21:32
@MontrealSergiy MontrealSergiy linked an issue Jul 2, 2024 that may be closed by this pull request
Optimize local DataProvider bindmounts for apptainer tasks #1394
Closed
prioux
prioux requested changes Mar 6, 2025
View reviewed changes
Copy link
Member

@prioux prioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

@MontrealSergiy MontrealSergiy changed the base branch from dev to master March 10, 2025 14:07
prioux
prioux requested changes Mar 10, 2025
View reviewed changes
Copy link
Member

@prioux prioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is all OK, two minor changes

  1. move the method as discussed at the end of Utility Methods (three blanks lines after, a single blank line before)
  2. ajust the other blank lines that are added/removed

@MontrealSergiy MontrealSergiy requested a review from prioux March 10, 2025 18:25
@MontrealSergiy
Copy link
Contributor Author

empty lines corrected

@prioux prioux merged commit 6c2cae6 into aces:master Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natacha-beck natacha-beck Awaiting requested review from natacha-beck

@prioux prioux Awaiting requested review from prioux

Assignees

@MontrealSergiy MontrealSergiy

Labels
Boutiques Boutiques integration Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize local DataProvider bindmounts for apptainer tasks
2 participants
@MontrealSergiy @prioux