Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for run_dicom_archive_validation.py #1242

Merged
merged 46 commits into from
Mar 19, 2025
Merged

Add integration test for run_dicom_archive_validation.py #1242

merged 46 commits into from
Mar 19, 2025

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Mar 14, 2025

No description provided.

@cmadjar cmadjar added Needs Work Before Merging Blocked Merge it and you die Area: CI PR or issue related to continuous integration, including automated tests and static checks labels Mar 14, 2025
@cmadjar cmadjar self-assigned this Mar 14, 2025
@cmadjar cmadjar added this to the 27.0 milestone Mar 14, 2025
@cmadjar
Copy link
Collaborator Author

cmadjar commented Mar 17, 2025

@maximemulder HEEEEELP please :) Do you know why suddenly the dicom_loader test might be failing. Maybe I will have a revelation during the night but in case that does not come, I figured I would ask ;)

@maximemulder
Copy link
Contributor

@cmadjar I ran the tests manually on #1239 and got the same error. I guess something else must have happened, maybe the file is not in the S3 bucket anymore ? Need to investigate.

@cmadjar
Copy link
Collaborator Author

cmadjar commented Mar 18, 2025

Mmmm.. The file is there. Could this be an issue with S3 connection? Rerunning the tests now to check if that resolved. If so, then I guess something was wrong with S3...

cmadjar added 24 commits March 18, 2025 14:32
@cmadjar
add test to check invalid arguments
e5c0687
@cmadjar
add test to check invalid arguments
82ae9e9
@cmadjar
add test to check invalid arguments
58d03f5
@cmadjar
add test to check invalid arguments
9221943
@cmadjar
add test to check path of the tarchive
18e5183
@cmadjar
add test to check path of the tarchive
4378939
@cmadjar
add test to check if uploadID exists
91514a6
@cmadjar
add test to check if uploadID exists
8719bec
@cmadjar
add test to check if uploadID exists
5505ea2
@cmadjar
add test to check if uploadID exists
d1297af
@cmadjar
add test to check if uploadID exists
fede4a6
@cmadjar
add test to check if uploadID exists
4be3065
@cmadjar
add test to check if uploadID exists
c1f74f9
@cmadjar
add test to check if uploadID exists
be7f006
@cmadjar
add test dataset specific for dicom_archive_validation tests
b0ee015
@cmadjar
remove unused variable
8098849
@cmadjar
remove unused variable
9bbf730
@cmadjar
remove unused variable
afa151e
@cmadjar
remove unused variable
d067ba0
@cmadjar
fix error message
cbd6807
@cmadjar
fix error message
1acdc85
@cmadjar
add test on mixed up uploadID and tarchive path
184d9c5
@cmadjar
add test on mixed up uploadID and tarchive path
efe249f
@cmadjar
fix session is still None
4ab2e05
@cmadjar cmadjar merged commit 6fc0832 into aces:main Mar 19, 2025
9 checks passed
@cmadjar cmadjar removed Needs Work Before Merging Blocked Merge it and you die labels Mar 19, 2025
@cmadjar cmadjar linked an issue Mar 20, 2025 that may be closed by this pull request
python/scripts/run_dicom_archive_validation.py (implement automated tests) #1240
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximemulder maximemulder maximemulder approved these changes

Assignees

@cmadjar cmadjar

Labels
Area: CI PR or issue related to continuous integration, including automated tests and static checks
Projects
None yet
Milestone
27.0
Development

Successfully merging this pull request may close these issues.

python/scripts/run_dicom_archive_validation.py (implement automated tests)
2 participants
@cmadjar @maximemulder