View previous logins says Windows 10 although I am using Windows 11

[tobias9931]

Describe the bug
If you go to View previous logins under My Account in MeshCentral, the last logins are displayed correctly.
However, the operating system is Windows 10 instead of Windows 11.

[tobias9931]

[si458]

The chances are we just need to update the browser detect js file/function, will look into it
What browser/os did u use?
(If u had filled in the bug template I wouldn't need to ask this hehe)

[tobias9931]

Sorry hehe
I use Chrome 134.0.6998.89 and Edge 134.0.3124.72
I think Microsoft is to blame for the problem...
We also have other software that thinks our client is using Windows 10 even though we are already on Windows 11.
Microsoft seems not to have updated a few attributes.
It doesn't seem to matter whether Windows 11 is 23H2 or 24H2.
Can you reproduce the problem for yourself?

[si458]

Will try when I get into work, I use mac mainly do the useragent is ALWAYS wrong because Apple haven't updated it since the release of osx 11

[si458]

by default the user-agent for my windows 11 edge browser still shows windows 10
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/134.0.0.0 Safari/537.36 Edg/134.0.0.0

we are using ua-parser-js npm package (v1.0.39)

HOWEVER if we upgrade to their latest and greatest version (v2+) and enable what they call Client Hints in the requests

we can get extra information and get the correct OS/Browser!

visit https://uaparser.dev on a browser and click demo to see your agent detected correctly because of the Client Hints

BUT plop in the browser agent manually, and it goes back to detecting windows 10
because you didnt provide Client Hintsand this is what v1 current

https://uaparser.dev/?ua=Mozilla/5.0%20(Windows%20NT%2010.0;%20Win64;%20x64)%20AppleWebKit/537.36%20(KHTML,%20like%20Gecko)%20Chrome/134.0.0.0%20Safari/537.36%20Edg/134.0.0.0#download

now the problem we have is ua-parser-js changed its license from MIT to AGPL for v2

and from asking ChatGPT/Deepseek, if this was OK as our project uses Apache Licence 2.0 and is opensource,

they are BOTH very certain this will cause problems with our project and Licences

so im not too sure what to do?

do we just upgrade to v2+ and say fuck it! or do i ask a lawyer for advise?

[si458]

Ok, I've found a workaround curtsey of ua-parser-js! And tested and seems to work!
So, I will do a little bit more of testing first!
It seems the Client Hint headers work in chrome/edge so it's detecting properly hehe
Just not for firefox but better than nothing!!!

[si458]

All Done!
ive implemented the Sec-UA (Client Hint) which will help us detect other things in the future!

this works for chrome + edge anyways on mac/windows from my testing

it doesnt work/isnt supported for firefox but still one step closer!

also weirdly enough Windows 11 using edge/chrome is actually detected as version 19 for some weird reason?
so we asume that its actually windows 11 if its windows and more than 13

FYI ua-parser-js actually do this too
https://github.com/faisalman/ua-parser-js/blob/master/src/main/ua-parser.js#L1288

sample outputs we get from browsers now that support the extra headers!

sec-ch-ua = '"Chromium";v="134", "Not:A-Brand";v="24", "Microsoft Edge";v="134"'
sec-ch-ua-arch = '"x86"'
sec-ch-ua-bitness = '"64"'
sec-ch-ua-form-factors = '"Desktop"'
sec-ch-ua-full-version = '"134.0.3124.72"'
sec-ch-ua-full-version-list = '"Chromium";v="134.0.6998.89", "Not:A-Brand";v="24.0.0.0", "Microsoft Edge";v="134.0.3124.72"'
sec-ch-ua-mobile = '?0'
sec-ch-ua-model = '""'
sec-ch-ua-platform = '"Windows"'
sec-ch-ua-platform-version = '"19.0.0"'
sec-ch-ua-wow64 = '?0'

sec-ch-ua = '"Chromium";v="134", "Not:A-Brand";v="24", "Google Chrome";v="134"'
sec-ch-ua-arch = '"x86"'
sec-ch-ua-bitness = '"64"'
sec-ch-ua-form-factors = '"Desktop"'
sec-ch-ua-full-version = '"134.0.6998.118"'
sec-ch-ua-full-version-list = '"Chromium";v="134.0.6998.118", "Not:A-Brand";v="24.0.0.0", "Google Chrome";v="134.0.6998.118"'
sec-ch-ua-mobile = '?0'
sec-ch-ua-model = '""'
sec-ch-ua-platform = '"macOS"'
sec-ch-ua-platform-version = '"14.7.4"'
sec-ch-ua-wow64 = '?0'