-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Alterations & APPDATA Reflection #218
base: master
Are you sure you want to change the base?
Conversation
Altered APPDATA path from HorseMenu to Terminus
Updated Screenshot
Updated Screenshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think that we should have some sort of file migration logic so the files don't get all reset when the location is changed, for example I have a large player DB that I wouldn't want to have to copy manually.
Could you send your settings file for analysis to make sure something else isn't at fault? |
settings.json was a fresh folder, i just did a reinstall on my pc a few days ago, too so horsemenu folder isnt in appdata, just terminus. |
This is a good idea, should we just implement a check to see if the HorseMenu folder exists in APPDATA and just copy the files from that into Terminus folder? We could optionally leave the HorseMenu folder in APPDATA as well, or have it delete it after the files are copied. Maybe an onboarding screen like YimMenu has with options to select if you would like to scan for horsemenu and merge your old data to terminus? |
Yeah I would say something like this. I will probably develop this feature myself, but I just wanted to get opinions on here. |
@@ -21,7 +21,7 @@ namespace YimMenu | |||
{ | |||
static DWORD Main(void*) | |||
{ | |||
const auto documents = std::filesystem::path(std::getenv("appdata")) / "HorseMenu"; | |||
const auto documents = std::filesystem::path(std::getenv("appdata")) / "Terminus"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda misleading having it named documents and it being in appdata, i think we should actually move this to documents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would make sense. I am fine with appdata but if we are going to migrate anyway we might aswell move it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda misleading having it named documents and it being in appdata, i think we should actually move this to documents.
I think this would be a good idea, would make it easier for people to locate the Terminus folder
Reflected the appdata folder to Terminus instead of HorseMenu
Altered the UI with a more modern design
Also, found a bug with the menu. It seems you cannot throw any throwable items (Fire bottle, Dynamite, Tomahawk, Bolas, etc.)