Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore constants in the legality error #31

Merged
merged 1 commit into from
May 25, 2023

Conversation

mgehre-amd
Copy link
Collaborator

This redirects the error message to talk about the actual problematic ops like cumsum.

@mgehre-amd mgehre-amd requested a review from ljfitz May 24, 2023 16:03
@mgehre-amd mgehre-amd force-pushed the matthias.ignore_constant branch from 6dc6be0 to 162ed96 Compare May 24, 2023 16:19
Copy link
Collaborator

@ljfitz ljfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I remember you discussing/contributing something like this upstream already. Was that for torch-to-linalg?

@mgehre-amd
Copy link
Collaborator Author

Great! I remember you discussing/contributing something like this upstream already. Was that for torch-to-linalg?

The last thing I contributed was emitting an explicit "This operator is unsupported" error when we see a torch.operator { name = "torch.aten.cumsum"}

@mgehre-amd mgehre-amd merged commit f57c080 into feature/misc_fixes May 25, 2023
@mgehre-amd mgehre-amd deleted the matthias.ignore_constant branch May 25, 2023 06:32
mgehre-amd added a commit that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants