Legalize sqrt to tosa

[ttjost]

No description provided.

[mgehre-amd]

There is already an end2end test for sqrt (look for ElementwiseSqrtModule). Can you add it to the TOSA_PASS set in e2e_testing/xfail_sets.py?
You can then run it locally via ./tools/e2e_test.sh --config=tosa -v -f ElementwiseSqrtModule

Then you also don't need the IR tests. torch-mlir uses end2end tests for almost everything, and will reject PRs that add IR unit tests when they can also be covered by end2end.

[mgehre-amd]

LGTM!

• Please do the test changes

[ttjost]

There is already an end2end test for sqrt (look for ElementwiseSqrtModule). Can you add it to the TOSA_PASS set in e2e_testing/xfail_sets.py? You can then run it locally via ./tools/e2e_test.sh --config=tosa -v -f ElementwiseSqrtModule

Then you also don't need the IR tests. torch-mlir uses end2end tests for almost everything, and will reject PRs that add IR unit tests when they can also be covered by end2end.

Did not know that. Thanks for letting me know. I'll update PR.