Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SliceCopyMax_Module: Fix crash #13

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

mgehre-amd
Copy link
Collaborator

@mgehre-amd mgehre-amd commented May 19, 2023

related upstream PR: llvm#1970

Compiling SliceCopyMax_Module_basic...
python: ../externals/llvm-project/mlir/include/mlir/IR/StorageUniquerSupport.h:174: static ConcreteT mlir::detail::StorageUserBase<mlir::torch::Torch::ValueTensorType, mlir::torch::Torch::BaseTensorType, mlir::torch::Torch::detail::ValueTensorTypeStorage, mlir::detail::TypeUniquer>::get(mlir::MLIRContext *, Args...) [ConcreteT = mlir::torch::Torch::ValueTensorType, BaseT = mlir::torch::Torch::BaseTensorType, StorageT = mlir::torch::Torch::detail::ValueTensorTypeStorage, UniquerT = mlir::detail::TypeUniquer, Traits = <>, Args = <std::optional<llvm::ArrayRef<long>>, mlir::Type>]: Assertion `succeeded(ConcreteT::verify(getDefaultDiagnosticEmitFn(ctx), args...))' failed.

Due to rounding issue when converting the int64_t max end to float in AtenArangeStartStepOp
@mgehre-amd mgehre-amd force-pushed the mgehre.negative_idx branch from 673c68d to c536652 Compare May 19, 2023 10:41
Copy link

@gargaroff gargaroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see anything wrong with this, but I'm not familiar with the code & test, so feel free to wait for another review

@mgehre-amd mgehre-amd merged commit 7fdb269 into misc_fixes May 19, 2023
@mgehre-amd mgehre-amd deleted the mgehre.negative_idx branch May 19, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants